[Webkit-unassigned] [Bug 81701] [QT][WK2] webview API doc

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=81701





--- Comment #11 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2012-04-01 04:56:09 PST ---
(From update of attachment 134815)
View in context: https://bugs.webkit.org/attachment.cgi?id=134815&action=review

Nice

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1267
> +/*!
> +\qmlproperty url WebView::url
> +
> +The location of the currently displaying HTML page. This writable
> +property offers the main interface to load a page into a web view.
> +It functions the same as the \c{window.location} DOM property.
> +
> +\sa WebView::loadHtml(), WebView::onUrlChanged
> +*/

Maybe some info here about handling errors, what happens if the url cannot be loaded directly by us and will be downloaded ?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1293
> +\qmlproperty url WebView::icon

Some more info about the sizes, animated icons etc?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1295
> +The location of the currently displaying HTML page icon. This

This is commonly known as favicons.

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1334
> +\qmlproperty int WebView::loadProgress
> +
> +The amount of the page that has been loaded, expressed as an integer
> +percentage in the range from \c{0} to \c{100}.
> +
> +\sa WebView::onLoadProgressChanged

So if it is fully loaded it will be 100? I think this should be clarified

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1617
> +\qmlmethod void WebView::loadHtml(html, baseUrl)
> +
> +Loads the specified \a{html} string as the content of the web view.
> +(This method offers a lower-level alternative to the \c{url} property,
> +which references HTML pages via URL.)
>  
> -    External objects such as stylesheets or images referenced in the HTML
> -    document are located relative to \a baseUrl.
> +External objects such as stylesheets or images referenced by the HTML
> +string are located relative to the \a baseUrl.

I think an example of the base url would make sense

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1646
> +\qmlsignal WebView::onNavigationHistoryChanged()
> +
> +Occurs when session history changes.
> +*/
> +

reference to goBack etc?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1669
> +\o \c{status}: Reflects one of three load states:
> +\c{LoadStartedStatus}, \c{LoadSucceededStatus}, or
> +\c{LoadFailedStatus}. See \c{WebView::LoadStatus}.
> +
> +\o \c{errorString}: description of load error.

I think there were a bug adding yet another state here. LoadStoppedStatus or so

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1694
> +\qmlsignal WebView::onUrlChanged()
> +
> +Occurs when a URL changes in any way.
> +*/

What about redirections?

> Source/WebKit2/UIProcess/API/qt/qquickwebview.cpp:1710
> +that are not canceled with \c{preventDefault()}.)  The \a{hoveredUrl}

cancelled ?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.