[Webkit-unassigned] [Bug 69151] [Qt][WK2] Synchronize tiling with accelerated compositing

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69151





--- Comment #2 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-09-30 15:45:45 PST ---
(From update of attachment 109313)
View in context: https://bugs.webkit.org/attachment.cgi?id=109313&action=review

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:247
> +    bool found = false;

exists?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:256
> +    if (!m_transforms.target.isInvertible())

// not visible?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:389
> +
> +

only one newline

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:393
> +        HashMap<int, ManagedTile>::iterator endIterator = m_managedTiles.end();

normally just called end in webkit

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:400
> +            else if (opacity > 0.95)
> +                tiles.prepend(&it->second);

comment?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:404
> +        TransformationMatrix scaledMatrix = m_transforms.target;
> +        TransformationMatrix replicaMatrix;

is this needed?

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.cpp:719
> -            m_tiles.clear();
> +            m_basicTiles.clear();

owned/adopted tiles. externallyManagedTiles

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.h:111
> +    enum TileMode {

TileOwnership { Externally , I...

> Source/WebCore/platform/graphics/texmap/TextureMapperNode.h:245
> +        bool backBufferUpdated;

isBack....

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.