[Webkit-unassigned] [Bug 68572] Create unit tests for LayerChromium

Fri Sep 30 14:03:09 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=68572

James Robinson <jamesr at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108896|review?                     |review+
               Flag|                            |

--- Comment #17 from James Robinson <jamesr at chromium.org>  2011-09-30 14:03:09 PST ---
(From update of attachment 108896)
View in context: https://bugs.webkit.org/attachment.cgi?id=108896&action=review

R=me. To upload a new patch to fix the nits and request commit, but without requiring a new review, replaced 'Reviewed by NOBODY (OOPS!).' in the ChangeLog with 'Reviewed by James Robinson.' and do:

webkit-patch upload --no-review --request-commit

> Source/WebKit/chromium/tests/LayerChromiumTest.cpp:56
> +    LayerChromiumWithInstrumentedDestructor(CCLayerDelegate* delegate)

nit: explicit keyword on 1-arg constructors, please.

c++ got the default wrong for this behavior - i think you should have to say 'implicit' to get implicit type conversion behavior. it's super annoying :(

> Source/WebKit/chromium/tests/LayerChromiumTest.cpp:262
> +    // The child delegate notifySynRequired should not be called when inserting.

typo: notifySynRequired->notifySyncRequired

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.