[Webkit-unassigned] [Bug 68684] spec change - option.label should be reflected like option.value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68684





--- Comment #12 from Darin Adler <darin at apple.com>  2011-09-30 09:46:55 PST ---
(From update of attachment 109284)
View in context: https://bugs.webkit.org/attachment.cgi?id=109284&action=review

> Source/WebCore/html/HTMLOptionElement.cpp:225
> +    // Use the text if the Label wasn't set. Also strip leading and trailing html whitespace.

This comment says what we are doing, but not why. Comments need to say “why” or be omitted. The code already says what it does.

>> Source/WebCore/html/HTMLOptionElement.cpp:228
>> +    //we want to collapse our html whitespace within the text too.
> 
> Should have a space between // and comment  [whitespace/comments] [4]

Same problem. Another what comment.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.