[Webkit-unassigned] [Bug 69128] Should call checkTextOfParagraph() indirectly to make unifying spell-checking code path easy
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 30 00:02:41 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=69128
WebKit Review Bot <webkit.review.bot at gmail.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |webkit.review.bot at gmail.com
--- Comment #2 from WebKit Review Bot <webkit.review.bot at gmail.com> 2011-09-30 00:02:41 PST ---
Attachment 109258 did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/accessibility/Accessibility..." exit_code: 1
Source/WebCore/editing/TextCheckingHelper.h:98: The parameter name "client" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebCore/editing/Editor.cpp:1892: An else statement can be removed when the prior "if" concludes with a return, break, continue or goto statement. [readability/control_flow] [4]
Source/WebCore/editing/Editor.cpp:1980: One line control clauses should not use braces. [whitespace/braces] [4]
Source/WebCore/editing/Editor.cpp:3238: One line control clauses should not use braces. [whitespace/braces] [4]
Total errors found: 4 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list