[Webkit-unassigned] [Bug 69127] [EFL] Enabling the Page Visibility API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69127


Gyuyoung Kim <gyuyoung.kim at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gyuyoung.kim at samsung.com




--- Comment #6 from Gyuyoung Kim <gyuyoung.kim at samsung.com>  2011-09-30 00:00:06 PST ---
(In reply to comment #5)
> Dear Grzegorz.
> 
> I will update the patch regarding your comments.
> 
> 
> But there is one issue.
> What you said is, "Setter functions in WebKit-EFL tend to return Eina_Bool instead of void to notify whether changes were applied.".
> The return type of this setter function is void, because the return type of the "setVisibilityState()" function of WebCore::Page is void.
> There is no way to know whether changes were applied in WebCore, so I think it's better to remain the return type of this setter function as "void".

In efl port, we have returned EINA_TRUE or EINA_FALSE despite return type of internal calling function is void. Because, we are using smart data by means of evas object for webview as below,

EWK_VIEW_SD_GET_OR_RETURN(o, sd, EINA_FALSE);
EWK_VIEW_PRIV_GET_OR_RETURN(sd, priv, EINA_FALSE);

So, if we can't get smart data via evas object, we need to return EINA_FALSE to inform this failure to application.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.