[Webkit-unassigned] [Bug 69127] [EFL] Enabling the Page Visibility API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69127


Grzegorz <g.czajkowski at samsung.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |g.czajkowski at samsung.com




--- Comment #4 from Grzegorz <g.czajkowski at samsung.com>  2011-09-29 23:29:13 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=109253&action=review

> Source/WebKit/efl/ewk/ewk_view.cpp:3785
> +void ewk_view_visibility_state_set(Evas_Object* o, Ewk_Page_Visibility_State page_visible_state, Eina_Bool initial_state)

Setter functions in WebKit-EFL tend to return Eina_Bool instead of void to notify whether changes were applied.

> Source/WebKit/efl/ewk/ewk_view.cpp:3801
> +    default:

Default statement is unnecessary in this patch.

> Source/WebKit/efl/ewk/ewk_view.cpp:3805
> +    DBG("PAGE_VISIBILITY_API is disabled.\n");

\n will be added by EINA.

> Source/WebKit/efl/ewk/ewk_view.h:2170
> +/// Defines the page visibility status

Missing dot.

> Source/WebKit/efl/ewk/ewk_view.h:2182
> + * @param page_visible_state It is the visible state of the page.

"It is" is not necessary. What do you say about:
@param page_visible_state the visible state of the page to set

> Source/WebKit/efl/ewk/ewk_view.h:2183
> + * @param initial_state It is true only when this function is called at page initialization.

I would rather prefer to use:
@param initial_state @c EINA_TRUE to ... or @c EINA_FALSE to ...

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.