[Webkit-unassigned] [Bug 69121] run-api-tests fails on chromium-win bot

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69121





--- Comment #4 from Xianzhu Wang <wangxianzhu at chromium.org>  2011-09-29 20:52:52 PST ---
(From update of attachment 109244)
View in context: https://bugs.webkit.org/attachment.cgi?id=109244&action=review

>> Tools/Scripts/run-api-tests:68
>> +  --[no-]build          Build (or do not build) unit tests prior to running (default: $buildDefault. No use for Chromium as buile-webkit builds everything)
> 
> Not used for Chromium because build-webkit builds everything
> 
> Actually, I'd skip this part of the change.

Done.

>> Tools/Scripts/run-api-tests:85
>> +buildTestTool() if $build && !isChromium();
> 
> I'd also skip this part.

Done.

>> Tools/Scripts/run-api-tests:285
>> +    my $buildProcess = open3($childIn, $childOut, $childErr, "perl", $pathToBuildTestTool, @args) or die "Failed to run " . $buildTestTool;
> 
> This is the only part that's needed.
> 
> Are you sure you don't need to put $pathToBuildTestTool into @args?  I'm somewhat of a Perl novice.  :)

I saw the same usage in old-run-webkit-tests (line 1444), and it works at least on Linux. I'm Perl novice too :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.