[Webkit-unassigned] [Bug 69048] Separate compositor platform support from webkit's platform support

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69048





--- Comment #14 from James Robinson <jamesr at chromium.org>  2011-09-29 18:53:58 PST ---
(In reply to comment #11)
> This might be better:
> 
>   struct WebKitInitializationOptions {
>       bool initializeV8;
>       bool initializeCompositor;
>       // ... default ctor sets them to true ...
>   };
>   WEBKIT_EXPORT void initializeWithOptions(WebKitPlatformSupport*, const WebKitInitializationOptions&);
> 

The initialization for v8 and for the compositor isn't really initializing anything - it's more binding gloop together so that it'll work together.  We use V8 in the browser process but still call initializeWithoutV8() cos we don't bind V8 and WebKit together in the browser.

One issue with this sort of API is that it seems to imply that a caller can reasonably set any combination and expect it to work.  In practice we only have two configs that are important - the one the renderer uses (webkit should initialize, bind to v8 and bind to compositor) and the one the browser and utility process (webkit should initialize but not bind to either).

Maybe we need an initialize(), bindToV8(), bindToCompositor()?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.