[Webkit-unassigned] [Bug 69058] DFG operation calls should be stdcall in Linux JSVALUE32_64 DFG JIT

Thu Sep 29 12:09:35 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69058

Geoffrey Garen <ggaren at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109153|review?                     |review-
               Flag|                            |

--- Comment #5 from Geoffrey Garen <ggaren at apple.com>  2011-09-29 12:09:35 PST ---
(From update of attachment 109153)
View in context: https://bugs.webkit.org/attachment.cgi?id=109153&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:55
> +#if CPU(X86) && COMPILER(GCC)

I don't think GCC is the right test here. It will definitely be wrong for people building with clang. But I think it may also be wrong for people building with GCC on non-cdecl platforms, since cdecl is a property of the platform ABI, not the compiler.

I'd suggest (OS(DARWIN) || OS(LINUX)) here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.