[Webkit-unassigned] [Bug 69089] New: EWS bots shouldn't die if a buggy patch with r? modifies the source code of the EWS

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69089

           Summary: EWS bots shouldn't die if a buggy patch with r?
                    modifies the source code of the EWS
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: Tools / Tests
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: ossy at webkit.org


https://bugs.webkit.org/attachment.cgi?id=109089 in https://bugs.webkit.org/show_bug.cgi?id=68973
killed all EWS bots, because the proposed patch updated the code of the EWS, and it was incorrect.

I think we should find a way to protect EWS from buggy python patches in bugzilla with r? .


error log:

Failed to run "['/storage/WebKit-qt-ews/Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-i..." exit_code: 1

Traceback (most recent call last):
  File "/storage/WebKit-qt-ews/Tools/Scripts/webkit-patch", line 74, in <module>
    main()
  File "/storage/WebKit-qt-ews/Tools/Scripts/webkit-patch", line 67, in main
    from webkitpy.tool.main import WebKitPatch
  File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/tool/main.py", line 39, in <module>
    from webkitpy.tool import commands
  File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/tool/commands/__init__.py", line 6, in <module>
    from webkitpy.tool.commands.download import *
  File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/tool/commands/download.py", line 32, in <module>
    from webkitpy.tool import steps
  File "/storage/WebKit-qt-ews/Tools/Scripts/webkitpy/tool/steps/__init__.py", line 32, in <module>
    from webkitpy.tool.steps.applywatchlisttopatch import ApplyWatchListToPatch
ImportError: No module named applywatchlisttopatch

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.