[Webkit-unassigned] [Bug 68371] [GTK][WEBKIT2] Add WebKitWebSettings GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68371





--- Comment #36 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-09-29 03:25:40 PST ---
(In reply to comment #33)
> (From update of attachment 109141 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=109141&action=review
> 
> >> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:41
> >> +        preferences = WKPreferencesCreate();
> > 
> > Why did you remove default values initialization?
> 
> Property set function gets called when we install the property using g_object_class_install_property, with the default value passed as g_param_spec (http://developer.gnome.org/gobject/unstable/gobject-The-Base-Object-Type.html#g-object-class-install-property), thus setting the WebKit preference to the one specified via g_param_spec. Hence it is not necessary to initialize them separately.

property_set function is called on an object instance, while g_object_class_install_property() is called on the object class struct, so there isn't any instance to call set_property when installing properties for a class.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.