[Webkit-unassigned] [Bug 68371] [GTK][WEBKIT2] Add WebKitWebSettings GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68371





--- Comment #32 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-09-29 02:53:58 PST ---
(From update of attachment 109141)
View in context: https://bugs.webkit.org/attachment.cgi?id=109141&action=review

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:41
> +        preferences = WKPreferencesCreate();

Why did you remove default values initialization?

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:402
> + * Returns: %TRUE If JavaScript is enabled.
> + *          %FALSE If JavaScript is not enabled.

This looks a bit redundant, maybe you could use something like %TRUE if JavaScript is enabled, %FALSE otherwise.

> Source/WebKit2/UIProcess/API/gtk/tests/testwebsettings.c:100
> +    return g_test_run ();

extra space there.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.