[Webkit-unassigned] [Bug 69028] Add getSubstringFromRange() and modify selectionRange() for chromium

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69028





--- Comment #2 from James Su <suzhe at chromium.org>  2011-09-29 01:59:50 PST ---
I'm not authorized to add comment to the patch. Just paste my comment here:

View in context: https://bugs.webkit.org/attachment.cgi?id=109076&action=review

And it's probably reasonable to rename WebWidget::caretOrSelectionRange() to selectionRange() to match the name of other similar methods.
I'm not qualified for reviewing the actual implementation, please find a webkit reviewer to help review that part.

> Source/WebKit/chromium/public/WebWidget.h:148
>      virtual bool getSelectionOffsetsAndTextInEditableContent(WebString&, size_t& focus, size_t& anchor) const { return false; }

Will this method be deprecated in favor of getSubstringFromRange()? If yes, then I suggest to add a comment and then remove it in an upcoming CL.

> Source/WebKit/chromium/public/WebWidget.h:155
>      virtual WebRect caretOrSelectionBounds() { return WebRect(); }

ditto.

> Source/WebKit/chromium/public/WebWidget.h:-159
> -    virtual bool selectionRange(WebPoint& start, WebPoint& end) const { return false; }

You cannot remove this method in this CL, otherwise you will break chrome code. Removing this method in an upcoming CL after landing this CL and migrating chrome to use to new methods.
So just add a comment in this CL stating that this method has been deprecated.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.