[Webkit-unassigned] [Bug 69058] Explicitly wrap DFG operations with FunctionPtr when being called in JSVALUE32_64 DFG JIT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=69058


Gavin Barraclough <barraclough at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109118|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #2 from Gavin Barraclough <barraclough at apple.com>  2011-09-28 23:59:31 PST ---
(From update of attachment 109118)
Looks like this patch is pre r96293, is there still a problem post-r96293?
I don't think we want to take this change.  We should be able to give FunctionPtr an appropriate set of constructors.
If Linux defaults to stdcall, it is possible that the '#if CPU(X86) && COMPILER(GCC)' check in  DFGOperations.h should be '#if CALLING_CONVENTION_IS_CDECL'.
We should be able to fix the problem without littering the JIT with explicit constructor calls.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.