[Webkit-unassigned] [Bug 69046] DFG JIT Operations on 32_64 should use stdcall calling convention.

Wed Sep 28 18:13:37 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=69046

Sam Weinig <sam at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109106|review?                     |review+
               Flag|                            |

--- Comment #3 from Sam Weinig <sam at webkit.org>  2011-09-28 18:13:37 PST ---
(From update of attachment 109106)
View in context: https://bugs.webkit.org/attachment.cgi?id=109106&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerCodeRef.h:59
> +// Defined on X86 platforms if stdcall is not the standard!
> +#define STDCALL_NOT_STANDARD __attribute__ ((stdcall))

How about we replace the second standard with default.  This should probably be in Compiler.h.

> Source/JavaScriptCore/dfg/DFGJITCodeGenerator.h:1319
> +#if !PLATFORM(MAC)

Please give this #define a more clear explanation.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.