[Webkit-unassigned] [Bug 67930] Implement flick gesture in Chromium Gesture Recognizer

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67930





--- Comment #7 from Varun Jain <varunjain at chromium.org>  2011-09-28 16:30:43 PST ---
(In reply to comment #5)
> (From update of attachment 107062 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=107062&action=review
> 
> looks good to me.
> 
> > Source/WebCore/ChangeLog:8
> > +        No new tests. (OOPS!)
> 
> Not so! You wrote unit tests. And if you leave this in, the commit queue will bounce the CL.

Done

> 
> > Source/WebCore/platform/chromium/GestureRecognizerChromium.cpp:40
> > +static const float minFlickSpeed = 1000.0;
> 
> I lowered this to 300.f (and you should have the trailing f to avoid a temporary.)

Done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.