[Webkit-unassigned] [Bug 68684] spec change - option.label should be reflected like option.value

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68684





--- Comment #7 from Darin Adler <darin at apple.com>  2011-09-28 09:36:23 PST ---
(From update of attachment 109001)
View in context: https://bugs.webkit.org/attachment.cgi?id=109001&action=review

> Source/WebCore/html/HTMLOptionElement.cpp:224
> +    return collectOptionInnerText(this).stripWhiteSpace();

It's OK to strip whitespace, but you need to do it with the HTML definition of whitespace, not the Unicode definition. So you don’t want to use the String function stripWhiteSpace. You want to do more like what OptionalElement::normalizeText does or use the stripLeadingAndTrailingHTMLSpaces function from HTMLParserIdioms.h. It's also important to cover this in test cases, including at least one test case with Unicode whitespace that should not be stripped because it does not meet the HTML standard’s definition of a space.

Also, we should double check that this stripping requirement is clear in the specification.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.