[Webkit-unassigned] [Bug 63933] HTML canvas strokes with dash and dashOffset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63933





--- Comment #20 from Young Han Lee <joybro201 at gmail.com>  2011-09-28 09:36:11 PST ---

> Do you plan to do rendering tests in another pass?

Yes, I will add pixel tests in the follow-up patch. So my plan is as follows:

1. patch for JS with basic tests.
2. patch for V8.
3. pixel tests.


> > Source/WebCore/bindings/js/JSCanvasRenderingContext2DCustom.cpp:181
> > +        float elem = valueArray->getIndex(i).toFloat(exec);
> 
> What about array elements that are not floats? Your testcase should test ctx.webkitLineDash['foo', {}] or something.

Non-floats can't pass the "!isfinite(elem)" check, and my testcase already has the test statement for a string argument;

shouldBe("trySettingLineDash([1, 'string'])", "[1.5, 2.5]");

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.