[Webkit-unassigned] [Bug 66936] [GStreamer] fullscreen video pause/play fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66936


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #105342|review?                     |review+
               Flag|                            |




--- Comment #8 from Martin Robinson <mrobinson at webkit.org>  2011-09-28 09:22:39 PST ---
(From update of attachment 105342)
View in context: https://bugs.webkit.org/attachment.cgi?id=105342&action=review

This looks sane to me.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:377
>  GstElement*
> -webkit_video_sink_new(void)
> +webkit_video_sink_new(WebCore::GStreamerGWorld* gstGWorld)

This should be one line.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:379
> +    GstElement* element = (GstElement*)g_object_new(WEBKIT_TYPE_VIDEO_SINK, 0);

Please use a C++-style cast or if GST_ELMENT is available, use that.

> Source/WebCore/platform/graphics/gstreamer/VideoSinkGStreamer.cpp:381
> +    WebKitVideoSink* sink = WEBKIT_VIDEO_SINK(element);
> +    sink->priv->gstGWorld = gstGWorld;

This should be one line.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.