[Webkit-unassigned] [Bug 68508] [GTK] Add WebKitError to GTK+ WebKit2 API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68508





--- Comment #6 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-09-28 09:16:35 PST ---
(In reply to comment #5)
> (From update of attachment 108993 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108993&action=review
> 
> > Source/WebKit2/GNUmakefile.am:1019
> > +			--fprod "\n/* enumerations from \"@filename@\" */" \
> 
> Please use: Enumerations from \"@filename@\."

Ok.

> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:28
> > +#define WEBKIT_NETWORK_ERROR webkit_network_error_quark ()
> 
> Is this a work-around for some issue or is it standard practice. If it's just a work-around I think we should just use webkit_network_error_quark everywhere.

This is standard practice.

> > Source/WebKit2/UIProcess/API/gtk/WebKitError.h:35
> > +    WEBKIT_NETWORK_ERROR_FAILED              = 399,
> > +    WEBKIT_NETWORK_ERROR_TRANSPORT           = 300,
> > +    WEBKIT_NETWORK_ERROR_UNKNOWN_PROTOCOL    = 301,
> > +    WEBKIT_NETWORK_ERROR_CANCELLED           = 302,
> > +    WEBKIT_NETWORK_ERROR_FILE_DOES_NOT_EXIST = 303
> 
> Please don't unalign these.

Ok.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.