[Webkit-unassigned] [Bug 68996] [GTK][WEBKIT2] Add Font and Encoding properties to WebKitWebSettings.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68996


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109007|1                           |0
        is obsolete|                            |




--- Comment #5 from Martin Robinson <mrobinson at webkit.org>  2011-09-28 08:44:18 PST ---
(From update of attachment 109007)
View in context: https://bugs.webkit.org/attachment.cgi?id=109007&action=review

> Source/WebKit2/ChangeLog:8
> +        Add font and encoding releated properties to WebKitWebSettings.
> +
> +        Provision to query and set the font related properties (such as
> +        font-family, font-size) and encoding properties (such as default-
> +        encoding) is added.
> +        https://bugs.webkit.org/show_bug.cgi?id=68996

ChangeLogs should be of the form

[bug title]
[bug url]

[other stuff]

> Source/WebKit2/ChangeLog:31
> +        * UIProcess/API/gtk/WebKitWebSettings.cpp:
> +        (webkitWebSettingsSetProperty):
> +        (webkitWebSettingsGetProperty):
> +        (webkit_web_settings_class_init):
> +        (WKStringGetCString):
> +        (webkit_web_settings_get_default_font_family):
> +        (webkit_web_settings_set_default_font_family):
> +        (webkit_web_settings_get_monospace_font_family):
> +        (webkit_web_settings_set_monospace_font_family):
> +        (webkit_web_settings_get_serif_font_family):
> +        (webkit_web_settings_set_serif_font_family):
> +        (webkit_web_settings_get_sans_serif_font_family):
> +        (webkit_web_settings_set_sans_serif_font_family):
> +        (webkit_web_settings_get_cursive_font_family):
> +        (webkit_web_settings_set_cursive_font_family):
> +        (webkit_web_settings_get_fantasy_font_family):
> +        (webkit_web_settings_set_fantasy_font_family):
> +        (webkit_web_settings_get_pictograph_font_family):
> +        (webkit_web_settings_set_pictograph_font_family):
> +        (webkit_web_settings_get_default_font_size):

Either fill these out or remove each method and make a summary. Having them blank is just noise.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:481
> +    * The default Serif font family used to display text.

Serif, sans-serif, cursive etc are not proper nounds and should not be capitalized.

> Source/WebKit2/UIProcess/API/gtk/WebKitWebSettings.cpp:1468
> +    WKPreferencesSetDefaultFontSize(priv->preferences, (uint32_t)fontSize);

Do not use C style casts. Can this be an implicit cast?  The documentation for all these methods should be explicit that the number accepted is in pixels and not points.

> Source/WebKit2/UIProcess/API/gtk/tests/testwebsettings.c:214
> +    // Default Pictograph Font Family font family is "serif"

Missing a period.

> Source/WebKit2/UIProcess/API/gtk/tests/testwebsettings.c:224
> +    // Default Default Font Size is 12.

Default Default.

> Source/WebKit2/UIProcess/API/gtk/tests/testwebsettings.c:246
> +    // Default Minimum Font Size is 5.

minimum font size shouldn't be capitalized.

> Source/WebKit2/UIProcess/API/gtk/tests/testwebsettings.c:256
> +    // Default Default encoding is "iso-8859-1"

Same issues + missing a period.

> Source/WebKit2/UIProcess/API/gtk/tests/testwebsettings.c:290
> +    g_test_add_func("/webkit2/websettings/defaultfontfamily", testWebKitWebSettingsDefaultFontFamily);
> +    g_test_add_func("/webkit2/websettings/monospacefontfamily", testWebKitWebSettingsMonospaceFontFamily);
> +    g_test_add_func("/webkit2/websettings/seriffontfamily", testWebKitWebSettingsSerifFontFamily);
> +    g_test_add_func("/webkit2/websettings/sansseriffontfamily", testWebKitWebSettingsSansSerifFontFamily);
> +    g_test_add_func("/webkit2/websettings/cursivefontfamily", testWebKitWebSettingsCursiveFontFamily);
> +    g_test_add_func("/webkit2/websettings/fanstasyfontfamily", testWebKitWebSettingsFantasyFontFamily);
> +    g_test_add_func("/webkit2/websettings/pictographfontfamily", testWebKitWebSettingsPictographFontFamily);
> +    g_test_add_func("/webkit2/websettings/defaultfontsize", testWebKitWebSettingsDefaultFontSize);
> +    g_test_add_func("/webkit2/websettings/defaultMonospaceFontSize", testWebKitWebSettingsDefaultMonospaceFontSize);
> +    g_test_add_func("/webkit2/websettings/minimumFontSize", testWebKitWebSettingsMinimumFontSize);
> +    g_test_add_func("/webkit2/websettings/defaultEncoding", testWebKitWebSettingsDefaultEncoding);

This can be one test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.