[Webkit-unassigned] [Bug 66496] [GTK] textInputController.doCommand is not implemented

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=66496


Chang Shu <cshu at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #109003|review?                     |review+
               Flag|                            |




--- Comment #4 from Chang Shu <cshu at webkit.org>  2011-09-28 06:23:50 PST ---
(From update of attachment 109003)
View in context: https://bugs.webkit.org/attachment.cgi?id=109003&action=review

Actually, I plan to modify the password echo tests to use eventSender, if possible, instead of textInputController.doCommand so they can be widely accepted. But it's nice to have this supported on GTK anyway. thanks.

> Source/WebKit/gtk/WebCoreSupport/DumpRenderTreeSupportGtk.cpp:601
> +    return;

this return can be removed.

> LayoutTests/ChangeLog:3
> +        Removed skipped tests under textInputController.doCommand for Gtk Port.

I usually still put the title here and some brief comments below.

> LayoutTests/platform/gtk/Skipped:-1548
> -

It's surprising but true that doCommand is used only in the above tests and some mac-specific tests. :)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.