[Webkit-unassigned] [Bug 68085] [GTK] Loader client implementation for WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68085





--- Comment #23 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-09-28 05:48:02 PST ---
(In reply to comment #22)
> (From update of attachment 108456 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108456&action=review
> 
> This looks good to me. I do not think we should add any sort of convenience API until we definitely understand how all these callbacks fit together. For example does a failure during provisional load also call didFailLoadWithErrorForFrame as well as didStartProvisionalLoadForFrame? Carlos, do you mind taking a peak at the loader  code in WebCore and writing the answer to that question somewhere in the gtkdoc?

Sure.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:59
> > +static void didStartProvisionalLoadForFrame(WKPageRef page, WKFrameRef frame, WKTypeRef userData, const void* clientInfo)
> 
> userData is unused, so the parameter name should be commented out.

Ok.

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:66
> > +    WebKitWebLoaderClient* client = WEBKIT_WEB_LOADER_CLIENT(clientInfo);
> > +    gboolean returnValue;
> > +    g_signal_emit(client, signals[PROVISIONAL_LOAD_STARTED], 0, &returnValue);
> 
> g_signal_emit takes a gpointer. Is it really necessary to cast clientInfo here?

Yes, clientInfo is a const void * while g_signal_emit() expects a void *. We can cast directly instead of using a local variable, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.