[Webkit-unassigned] [Bug 48544] support -webkit-tap-highlight-color

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48544





--- Comment #22 from Johnny(Jianning) Ding <jnd at chromium.org>  2011-09-27 18:22:03 PST ---
(In reply to comment #20)
> I would write:
> 
> Original code from the iOS WebCore code dump, extracted and modified by ....
> 
> I would leave out WebKit here.
Good suggestions, will change them in next update.
> 
> > Source/WebCore/rendering/style/StyleRareInheritedData.h:31
> > -#include <wtf/RefCounted.h>
> >  #include <wtf/PassRefPtr.h>
> > +#include <wtf/RefCounted.h>
> 
> Unrelated change... Should be in another patch
It's just to make style-check happy. (resolved include order issue)
> 
> > Source/WebCore/rendering/style/StyleRareInheritedData.h:81
> >      unsigned resize : 2; // EResize
> > -    unsigned userSelect : 1;  // EUserSelect
> > +    unsigned userSelect : 1; // EUserSelect
> >      unsigned colorSpace : 1; // ColorSpace
> 
> This change seems unreleated
ditto. (removed redundant space)

> 
> Stage? Sounds pretty strange. Event: touch start, or so would be more clear
> 
> 
> No need for these newlines
Will change them in next update.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.