[Webkit-unassigned] [Bug 54707] Introduce lookup-table based approach for applying CSS properties.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54707





--- Comment #79 from Dave Hyatt <hyatt at apple.com>  2011-09-27 16:57:37 PST ---
I think the mistake (and this is on me, since I was consulted before this work began) here is that this work probably should have been prototyped first and performance/memory tested after all properties were converted. Changing this incrementally has been taking far too long, and the result is the tree has been left in a half-converted state for a really long time.

I also am of the opinion that the new code is adding a lot of complexity and is pretty hard to follow. I'll confess that the many new CSS properties that I've added have all been to the switch statement, because the other code is more complicated. Let's face it. Advanced C++ can lead to some really inscrutable code, and I'm not really a fan of how this has all panned out.

My vote would be that we revert to the original approach of a giant switch statement and this work could perhaps continue on a branch or in a prototype and have to prove itself performance and footprint-wise before becoming the approach adopted by all properties.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.