[Webkit-unassigned] [Bug 48544] support -webkit-tap-highlight-color

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48544





--- Comment #20 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-09-27 14:38:17 PST ---
(From update of attachment 108849)
View in context: https://bugs.webkit.org/attachment.cgi?id=108849&action=review

> Source/WebCore/ChangeLog:8
> +        Based on tijiang at rim.com's patch which was based on some code in Apple IPhone's release tarball.

I would write:

Original code from the iOS WebCore code dump, extracted and modified by ....

> Source/WebCore/ChangeLog:12
> +        used as WebKit default tap highlight color.

I would leave out WebKit here.

> Source/WebCore/rendering/style/StyleRareInheritedData.h:31
> -#include <wtf/RefCounted.h>
>  #include <wtf/PassRefPtr.h>
> +#include <wtf/RefCounted.h>

Unrelated change... Should be in another patch

> Source/WebCore/rendering/style/StyleRareInheritedData.h:81
>      unsigned resize : 2; // EResize
> -    unsigned userSelect : 1;  // EUserSelect
> +    unsigned userSelect : 1; // EUserSelect
>      unsigned colorSpace : 1; // ColorSpace

This change seems unreleated

> LayoutTests/fast/events/touch/tap-highlight-color-expected.txt:7
> +Stage: touch start

Stage? Sounds pretty strange. Event: touch start, or so would be more clear

> LayoutTests/fast/events/touch/script-tests/tap-highlight-color.js:56
> +
> +

No need for these newlines

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.