[Webkit-unassigned] [Bug 68329] DFG should support continuous optimization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68329





--- Comment #37 from Filip Pizlo <fpizlo at apple.com>  2011-09-27 12:48:44 PST ---
(In reply to comment #36)
> (From update of attachment 108230 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108230&action=review
> 
> > Source/JavaScriptCore/heap/JettisonedCodeBlocks.h:58
> > +        // This checks for both of those nasty cases in one go.
> > +        // 0 + 1 = 1
> > +        // -1 + 1 = 0
> > +        if (value + 1 <= 1)
> > +            return;
> 
> Why not just value < 1 ?  I guess ptr_t is unsigned?

value is a uintptr_t, so yes.  value < 1 would only check for the zero case.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.