[Webkit-unassigned] [Bug 68833] Discard event data not followed by an empty line before eof when parsing an event-stream

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68833


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108858|review?                     |review+
               Flag|                            |




--- Comment #8 from Alexey Proskuryakov <ap at webkit.org>  2011-09-27 09:47:52 PST ---
(From update of attachment 108858)
View in context: https://bugs.webkit.org/attachment.cgi?id=108858&action=review

> Source/WebCore/page/EventSource.cpp:318
> +            if (!m_currentlyParsedEventId.isNull()) {

So, we're supposed to keep sending the same old last event id if subsequent events don't have one? Weird.

> Source/WebCore/page/EventSource.h:118
>          String m_lastEventId;

I now agree that keeping the name makes sense.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.