[Webkit-unassigned] [Bug 63616] Add missing methods used by fast/notifications tests to LayoutTestController

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63616





--- Comment #11 from Martin Robinson <mrobinson at webkit.org>  2011-09-27 09:40:38 PST ---
(From update of attachment 108808)
View in context: https://bugs.webkit.org/attachment.cgi?id=108808&action=review

> Tools/DumpRenderTree/LayoutTestController.cpp:-2496
> -void LayoutTestController::grantDesktopNotificationPermission(JSStringRef origin)
> -{
> -    m_desktopNotificationAllowedOrigins.push_back(JSStringRetain(origin));
> -}
> -
> -bool LayoutTestController::checkDesktopNotificationPermission(JSStringRef origin)
> -{
> -    std::vector<JSStringRef>::iterator i;
> -    for (i = m_desktopNotificationAllowedOrigins.begin();
> -         i != m_desktopNotificationAllowedOrigins.end();
> -         ++i) {
> -        if (JSStringIsEqual(*i, origin))
> -            return true;
> -    }
> -    return false;
> -}
> -

It might be good to explain in the ChangeLog why you remove the platform-independent implementation for these methods.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.