[Webkit-unassigned] [Bug 44886] Reflected attribute input.size wraps on negative values (Chrome), or returns them (Safari)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44886


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108789|review?, commit-queue?      |review+, commit-queue-
               Flag|                            |




--- Comment #15 from Darin Adler <darin at apple.com>  2011-09-27 09:39:58 PST ---
(From update of attachment 108789)
View in context: https://bugs.webkit.org/attachment.cgi?id=108789&action=review

r=me but I would prefer that the new test be improved as I describe in the comments, so I have not set commit-queue+

> LayoutTests/fast/dom/HTMLInputElement/input-default-size.html:10
> +<script src="script-tests/input-default-size.js"></script>

This is no longer the preferred style for new tests. Instead we prefer to put the actual test inside the HTML file. The separate ".js" file structure is only useful for pure JavaScript tests, and even in that case, only useful in theory.

Also, the coverage in this test is too narrow. A while test just for this one case seems overkill. We should cover more transitions in size, to make sure we test all aspects of the code. Like size-attribute but with a focus on changing from previous values of the size attribute.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.