[Webkit-unassigned] [Bug 63642] [Qt] Visual Studio 2010 compiler warning about TR1 support in JavascriptCore

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63642





--- Comment #8 from Rob Tomek <robt_0 at hotmail.com>  2011-09-27 09:30:06 PST ---
(In reply to comment #7)
> (From update of attachment 99123 [details])
> OK, those multiple Windows configs are hard to test. But if it breaks a bot, prepare for a rollout :)

The only two compilers that _HAS_TR1 even affects are VS2008 with the feature pack installed and VS2010. It looks like at one time that they wanted to block VS2008 with the feature pack and someone added _HAS_TR1 = 0, but someone else accomplished the same thing by putting in _MSC_VER >= 1600 around the TR1 commands. The VS2008 implementation of TR1 is not fully conforming, so I'm assuming that's why it is avoided. Basically, we have two fixes for the problem in place, with one causing an enormous amount of obnoxious warnings (and downgrading the VS2010 compiler).

gcc, icc, etc. will not be affected since _HAS_TR1 doesn't even do anything. Someone should just delete that line, or at least implement this patch, already.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.