[Webkit-unassigned] [Bug 68636] Accessibility: AXObjectCache is cleared unnecessarily when non-top Document is detached

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68636





--- Comment #3 from Dominic Mazzoni <dmazzoni at google.com>  2011-09-27 09:01:51 PST ---
(In reply to comment #2)
> (From update of attachment 108801 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108801&action=review
> 
> > Source/WebCore/dom/Document.cpp:1830
> > +
> 
> this has the ability to leak objects that came from an iframe until the whole document is cleared, does it not?

No, in the case where the iframe is actually deleted like this, I'm positive that AXObjectCache::remove is actually called on all of the accessibility objects within the iframe's tree. The objects are deleted when their reference count hits zero.

The test already confirms this by checking that the objects have lost their correct role, but I added my own debug logging to confirm it.

If there is any scenario where an iframe is detached but not either deleted or reattached somewhere else in the same page, then we could have a problem - but I can't think of any such circumstance.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.