[Webkit-unassigned] [Bug 24092] Autofocus readonly inputs

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=24092


Ryosuke Niwa <rniwa at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108796|review?                     |review-
               Flag|                            |




--- Comment #30 from Ryosuke Niwa <rniwa at webkit.org>  2011-09-27 00:34:20 PST ---
(From update of attachment 108796)
View in context: https://bugs.webkit.org/attachment.cgi?id=108796&action=review

> LayoutTests/fast/forms/autofocus-readonly-attribute.html:9
> +function runTest()
> +{
> +    if (window.layoutTestController)
> +        layoutTestController.dumpAsText();
> +}

It seems like there's no need for us to wrap this in a function. Please get rid of the function and just run if & dumpAsText().

> LayoutTests/fast/forms/autofocus-readonly-attribute.html:12
> +    var ele = document.getElementById("console");

Please don't use the abbreviation "ele".

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.