[Webkit-unassigned] [Bug 68345] pop-state-event-constructor.html crashes and fails

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68345





--- Comment #10 from Kentaro Hara <haraken at chromium.org>  2011-09-26 21:13:06 PST ---
(From update of attachment 108651)
View in context: https://bugs.webkit.org/attachment.cgi?id=108651&action=review

>> Source/WebCore/ChangeLog:17
>> +        popped from HistoryItem, but we cannot deserialize the SeriazliedScriptValue into
> 
> SeriazliedScriptValue => SerializedScriptValue

Thanks! Fixed.

>> Source/WebCore/ChangeLog:20
>> +        PopStateEvent still needs to provide an API to construct it with SeriazliedScriptValue.
> 
> SeriazliedScriptValue

Fixed.

>> Source/WebCore/bindings/v8/custom/V8PopStateEventCustom.cpp:46
>> +    return serializedState ? serializedState->deserialize() : event->state().v8Value();
> 
> Will this return undefined when the JSC version returns null?

Sorry, fixed it.

>> Source/WebCore/dom/PopStateEvent.cpp:61
>> +    , m_state()
> 
> We usually omit this declaration when we're just calling the default constructor.

Omitted.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.