[Webkit-unassigned] [Bug 68513] <input> with autofocus doesn't lose focus when it has a certain onblur listener

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68513


Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108637|review?                     |review-
               Flag|                            |




--- Comment #26 from Kent Tamura <tkent at chromium.org>  2011-09-26 19:07:52 PST ---
(From update of attachment 108637)
View in context: https://bugs.webkit.org/attachment.cgi?id=108637&action=review

> LayoutTests/fast/forms/autofocus-focus-only-once.html:22
> +    if (window.layoutTestController)
> +        layoutTestController.dumpAsText();
> +

These lines are not needed. js-test-pre.js does it.

> Source/WebCore/html/HTMLFormControlElement.h:104
> +    bool hasAutofocused() { return m_hasAutoFocused; }
> +    void setAutofocused(bool autofocused = true) { m_hasAutoFocused = autofocused; }
> +

Inconsistent capitalization: hasAuto*f*ocused vs. m_hasAuto*F*ocused
  Let's follow the capitalization of Document::m_ignoreAutofocus.  So it should be m_hasAuto*f*ocused.

Also, we don't need to use the default argument for setAutofocused().
  void setAutofocused() { m_hasAutofocused = true; }
is enough.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.