[Webkit-unassigned] [Bug 68833] Discard event data not followed by an empty line before eof when parsing an event-stream

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Sep 26 15:53:51 PDT 2011


https://bugs.webkit.org/show_bug.cgi?id=68833





--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2011-09-26 15:53:50 PST ---
(From update of attachment 108722)
View in context: https://bugs.webkit.org/attachment.cgi?id=108722&action=review

I see, that explains why we need two member variables.

Would "m_currentlyParsedEventId" and "m_latestCompleteEventId" work? You could also null out m_currentlyParsedEventId after transferring its value to m_latestCompleteEventId.

> Source/WebCore/page/EventSource.cpp:319
> +            if (!m_eventId.isNull())
> +                m_lastEventId = m_eventId;

What will break if this if() check is removed?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list