[Webkit-unassigned] [Bug 68457] Style changes applied to filtered elements do not invalidate the element

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68457





--- Comment #11 from Tim Horton <timothy_horton at apple.com>  2011-09-26 15:14:54 PST ---
(In reply to comment #9)
> (From update of attachment 108717 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108717&action=review
> 
> r- because I'd like an even more reduced test case. Also have a question to your patch itself.
> 
> Btw. Don't you have commit rights? Why do you set cq?
> 
> > LayoutTests/svg/filters/animate-fill.svg:6
> > +    <filter id="filt">
> > +        <feGaussianBlur stdDeviation="3" />
> > +    </filter>
> 
> Shouldn't we still use the filter code path if we don't have an effect at all? If not, even an offset effect (feOffset) without attributes would be enough.
> 
> > LayoutTests/svg/filters/animate-fill.svg:9
> > +    <clipPath id="clip">
> > +        <rect width="50px" height="50px" x="25" y="25" />
> > +    </clipPath>
> 
> Is it just reproducible with a clipPath? If you just used it to have a solid filled rect, the suggestion above should help.
> 
> > Source/WebCore/rendering/svg/SVGResourcesCache.cpp:152
> > +    SVGResources* resources = SVGResourcesCache::cachedResourcesForRenderObject(renderer);
> > +    if (!resources)
> > +        return;
> > +
> > +    resources->removeClientFromCache(renderer);
> 
> Do we still need to invalidate the client for clipPath? Is there a CSS property that could influence any visual affect on clipPath? IIRC SVGResourceCache is used for PaintServers as well (pattern and gradient), can you reproduce the problem for these resources as well?

Doesn't reproduce with the others. Perhaps a better approach would be to change the way we check for invalidation in RenderSVGResourceFilter::applyResource? Or clear the resource from m_filter elsewhere? I'll look for a different solution if you think this one is overkill.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.