[Webkit-unassigned] [Bug 68833] Discard event data not followed by an empty line before eof when parsing an event-stream

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68833





--- Comment #4 from Alexey Proskuryakov <ap at webkit.org>  2011-09-26 14:58:26 PST ---
(From update of attachment 108722)
View in context: https://bugs.webkit.org/attachment.cgi?id=108722&action=review

In other words, no explicit endorsement from IE. Still, seems fine to make this change.

> Source/WebCore/page/EventSource.cpp:247
> +        m_eventId = String();

We don't have a function that discards everything already?

> Source/WebCore/page/EventSource.h:118
> +        String m_eventId;
>          String m_lastEventId;

I'm not thrilled about having two eventId member variables. How are they different? Maybe "last" is actually "previous"? Can we encode this bit of state somehow else, without seemingly duplicating data?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.