https://bugs.webkit.org/show_bug.cgi?id=62092
Una Sabovic <una.sabovic at palm.com> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #108615|0 |1
is obsolete| |
Attachment #108615|review? |
Flag| |
Attachment #108693| |review?
Flag| |
--- Comment #60 from Una Sabovic <una.sabovic at palm.com> 2011-09-26 11:25:46 PST ---
Created an attachment (id=108693)
--> (https://bugs.webkit.org/attachment.cgi?id=108693&action=review)
proposed patch
Moved updatePositionForNodeRemoval to htmlediting instead of Position.
Removed editing delegates from LayoutTests/editing/inserting/typing-003.html
Calling runDumpAsTextEditingTest instead of runEditingTest also produced a lot of output so I took the other approach.
> LayoutTests/platform/qt/editing/selection/regional-indicators-expected.txt:5
> +FAIL document.getSelection().toString() should be ð¯ðµ. Was .
> This diff doesn't look good. Maybe you're missing some int'l package in your system?
I was also suspicious about this one but it is the expected behavior. When
>> div.innerText = "🇯🇵🇯🇵"; // line 21
The entire content is deleted making selection (start, end) = (0, 0). Then new content is inserted at the endpoints which doesn't move the start or end.
So we end up with an empty selection.
This test is strange with "FAIL" in its expected output.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.