[Webkit-unassigned] [Bug 63933] HTML canvas strokes with dash and dashOffset

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=63933





--- Comment #15 from Young Han Lee <joybro201 at gmail.com>  2011-09-26 07:49:35 PST ---
> is the if (elem <= 0) return; check not enough?

No. Infinite and NaN should be checked here. "if (elem <= 0 || !isfinite(elem)) return;" would be enough.


> Don't you want to raise a DOM exception on false values? setDOMException(exec, ec);

I believe we don't have to raise an exception here for the following reasons.

1. There seems to be no attribute raising an exception for false value. All DOM exception is raised only by methods, not attributes.

2. Setting lineWidth with false value isn't raising an exception. I think webkitLineDashOffset shouldn't also raise an exception for consistency. If so, it seems weird that webkitLineDash with false value raises an exception, but webkitLineDashOffset doesn't.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.