[Webkit-unassigned] [Bug 68592] wrap attribute of textarea element cannot be accessed by JavaScript

Mon Sep 26 07:13:35 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=68592

Kent Tamura <tkent at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108634|review?                     |review-
               Flag|                            |

--- Comment #8 from Kent Tamura <tkent at chromium.org>  2011-09-26 07:13:35 PST ---
(From update of attachment 108634)
View in context: https://bugs.webkit.org/attachment.cgi?id=108634&action=review

r- because of test style.

> Source/WebCore/html/HTMLTextAreaElement.idl:4
> + * Portions Copyright (C) 2011 Motorola Mobility, Inc.  All rights reserved.

You don't need to add "Portions".

> LayoutTests/fast/forms/textarea-wrap-attribute.html:10
> +<script src="script-tests/textarea-wrap-attribute.js"></script>

Do not add a separated .js file. This way is obsolete.
Please put the content of textarea-wrap-attribute.js into here, and remove textarea-wrap-attribute.js.

> LayoutTests/fast/forms/script-tests/textarea-wrap-attribute.js:10
> +//If wrap attribute present.

This comment (and the followings) is useful information. Please print it to the test result.  You can print it by debug('Check if wrap attribute present').

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.