[Webkit-unassigned] [Bug 68633] Optimize matching of common pseudo classes

Mon Sep 26 06:57:20 PDT 2011

https://bugs.webkit.org/show_bug.cgi?id=68633

Antti Koivisto <koivisto at iki.fi> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #108379|0                           |1
        is obsolete|                            |
 Attachment #108662|                            |review?
               Flag|                            |

--- Comment #8 from Antti Koivisto <koivisto at iki.fi>  2011-09-26 06:57:19 PST ---
Created an attachment (id=108662)
 --> (https://bugs.webkit.org/attachment.cgi?id=108662&action=review)
new approach

In the end I wasn't happy with the original patch. Here is an updated patch which takes slightly different approach. This uses separate lists for different pseudo class types instead putting everything to a single list. This both significantly faster (as the rightmost selector won't need any additional checking for match) and cleaner (no need for awkward templating of fastRejectSelector).

The patch also includes a bunch of cleanups as suggested by Darin.

Requesting a new review as the changes are substantial.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.