[Webkit-unassigned] [Bug 68085] [GTK] Loader client implementation for WebKit2 GTK+ API

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68085





--- Comment #17 from Carlos Garcia Campos <cgarcia at igalia.com>  2011-09-26 05:42:35 PST ---
(In reply to comment #16)
> (From update of attachment 108456 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108456&action=review
> 
> > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:272
> > +     * This signal is emitted when an error occurs when starting to
> > +     * load data for a page. By default, if the signal is not handled,
> > +     * a stock error page will be displayed. You need to handle the signal
> > +     * if you want to provide your own error page.
> 
> I assume you can handle this signal to avoid the currently loaded page to be replaced by the error page, for instance? Might be good mentioning it here.

I'm not sure I understand what you mean, it says that you need to handle the signal to provide your own error page. Do you mean it can be used to not show any error page at all?

> > Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp:318
> > +     * This signal is emitted when a page load complete, that is, when all
> > +     * the resources are done loading.
> > +     *
> > +     * This signal is emitted after #WebKitWebLoaderClient::load-committed.
> 
> What about that idea of also emiting a signal when the load stops either by finishing properly or by failing, giving us a single signal to know that the load try has finished?

Do you mean adding a new signal in addition to the current ones or replace finished and failed signals by a single finished signal?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.