[Webkit-unassigned] [Bug 68079] Set but unused variables cleanup in v8 bindings (gcc 4.6)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68079





--- Comment #12 from ph34r <pph34r at gmail.com>  2011-09-26 05:40:09 PST ---
> > Source/WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp:112
> > -        imp->setLength(value->Uint32Value(), ec);
> > +        imp->setLength(newLength, ec);
> 
> Can we write a test for this change?  Maybe passing a length greater than UINT_MAX?

I think there is no point, because the length is limited to 10k ( http://google.com/codesearch#OAMlx_jo-ck/src/third_party/WebKit/Source/WebCore/html/HTMLSelectElement.cpp&type=cs&l=479 ) and must have been covered by tests somewhere :)

I've uploaded a new patch, take a look please.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.