[Webkit-unassigned] [Bug 68746] wtf/BitVector.h has a variety of bugs which manifest when the vector grows beyond 63 bits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68746





--- Comment #8 from Darin Adler <darin at apple.com>  2011-09-23 20:24:29 PST ---
(From update of attachment 108570)
View in context: https://bugs.webkit.org/attachment.cgi?id=108570&action=review

> Source/JavaScriptCore/wtf/BitVector.cpp:38
> +    (*this) = other;

No need for these parentheses.

> Source/JavaScriptCore/wtf/BitVector.cpp:41
> +BitVector& BitVector::operator=(const BitVector& other)

It’s normally considered better style to write a swap function and a copy constructor and build the assignment operator from the copy constructor instead of the other way around.

Easier to get rid too.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.