[Webkit-unassigned] [Bug 68457] <animateColor> applied to filtered ellipse does not update

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68457





--- Comment #5 from Tim Horton <timothy_horton at apple.com>  2011-09-23 18:20:46 PST ---
So it looks like most style changes don't cause filter invalidation. Anything that requires relayout does, because then we go SVGResourcesCache::clientLayoutChanged -> RenderSVGResourceFilter::removeClientFromCache and remove the filter from RenderSVGResourceFilter::m_filter, which then causes us not to bail early in RenderSVGResourceFilter::applyResource (if we don't removeClientFromCache, we bail in the m_filter.contains(object) check).

Style changes don't end up calling removeClientFromCache, so the filter is still in m_filter, so we don't invalidate.

I'm not sure what the downsides to calling removeClientFromCache from SVGResourcesCache::clientStyleChanged might be (but have confirmed that copying the body of SVGResourcesCache::clientLayoutChanged (which does call removeClientFromCache) does solve this problem).

I'll fix it next week.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.