[Webkit-unassigned] [Bug 68746] wtf/BitVector.h has a variety of bugs which manifest when the vector grows beyond 63 bits

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=68746





--- Comment #4 from Filip Pizlo <fpizlo at apple.com>  2011-09-23 18:02:36 PST ---
(In reply to comment #3)
> (From update of attachment 108570 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=108570&action=review
> 
> r=me, but it would be worth considering whether ensureSize() should be inline or outline before landing
> 
> > Source/JavaScriptCore/wtf/BitVector.h:79
> > -    void ensureSize(size_t numBits)
> > -    {
> > -        if (numBits <= size())
> > -            return;
> > -        resizeOutOfLine(numBits);
> > -    }
> > +    void ensureSize(size_t numBits);
> 
> Do you really want to take ensureSize out of line? you already have resizeOutOfLine so it seems overkill to hoist the entire function out

That's a really good point.  I'll change that so that ensureSize() inlines the trivial path, and land.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.