[Webkit-unassigned] [Bug 67253] NRWT should show the size of the pixel image delta in results.html

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=67253





--- Comment #13 from Eric Seidel <eric at webkit.org>  2011-09-23 17:02:33 PST ---
(From update of attachment 108554)
View in context: https://bugs.webkit.org/attachment.cgi?id=108554&action=review

> Tools/Scripts/webkitpy/layout_tests/models/test_failures.py:171
>  class FailureImageHashMismatch(TestFailure):
>      """Image hashes didn't match."""
> +    def __init__(self, diff_percent=0):
> +        self.diff_percent = diff_percent

I feel like I've tried to add non-static data to these before and others have gotten sad.  The test_failures.py design is bad/broken.  We'll have to consult Ojan/Dirk here for suggestions.

>> Tools/Scripts/webkitpy/layout_tests/port/chromium.py:216
>> +        return [result, 0] # FIXME: how to get % diff?
> 
> at least two spaces before inline comment  [pep8/E261] [5]

It's sad, but true that our python vs. c++ comment spacing is different in webkit. :(

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.