[Webkit-unassigned] [Bug 68295] Remove preserves3D() from CCLayerDelegate
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Sep 23 14:55:52 PDT 2011
https://bugs.webkit.org/show_bug.cgi?id=68295
--- Comment #5 from James Robinson <jamesr at chromium.org> 2011-09-23 14:55:52 PST ---
(From update of attachment 108436)
View in context: https://bugs.webkit.org/attachment.cgi?id=108436&action=review
> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:367
> + platformLayer->setPreserves3D(m_preserves3D);
I don't think we need to do this - the canvas contents layer can't have preserves3D set since it's a CSS property and would only apply to the container layer, and even if it could we should be able to rely on the normal property propagation code
> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:400
> + layer->setPreserves3D(m_preserves3D);
same here - i don't think media layers can have this bit
> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:600
> + if (m_contentsLayer)
> + m_contentsLayer->setPreserves3D(m_preserves3D);
it looks like we used to propagate the preserves3D bit to the contents layer. this change preserves that behavior but I think it's actually wrong. Can you see if any tests break if you only propagate the preserves3D bit to the m_layer?
> Source/WebCore/platform/graphics/chromium/GraphicsLayerChromium.cpp:652
> + m_contentsLayer->setPreserves3D(m_preserves3D);
do we need this?
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list